Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where single-line declarations would include body #585

Merged
merged 2 commits into from
Jun 11, 2016
Merged

fix bug where single-line declarations would include body #585

merged 2 commits into from
Jun 11, 2016

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jun 10, 2016

fixes #226

@jpsim
Copy link
Collaborator Author

jpsim commented Jun 10, 2016

This also removes the { get } or { get set } in protocols, which probably isn't what we want. Thoughts?

@jpsim jpsim mentioned this pull request Jun 11, 2016
Closed
@jpsim jpsim mentioned this pull request Jun 11, 2016
Closed
@jpsim
Copy link
Collaborator Author

jpsim commented Jun 11, 2016

Fixes #586. I've decided to merge this even with the removal of { get } and { get set } from interfaces and have opened #591 to track fixing that at some point. I felt the tradeoff was worth it to get this in short term.

@jpsim jpsim merged commit 6341381 into master Jun 11, 2016
@jpsim jpsim deleted the jp-remove-body branch June 11, 2016 00:40
@pigeon-archive pigeon-archive modified the milestone: The Past Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpsim jpsim

Labels
bug enhancement github-review-accepted
Projects
None yet
Milestone
Before
Development

Successfully merging this pull request may close these issues.

Single-line computed property documentation renders source
2 participants
@jpsim @pigeon-archive